Add action to auto update gradle wrapper #5511
Conversation
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 |
There was a problem hiding this comment.
FYI @trask this task fails without installing the JDK. Didn't see any reference to this in the docs for the update-gradle-wrapper-action, but updating the wrapper requires running a gradle daemon, which requires java to be installed. Maybe update-gradle-wrapper-action installs a lower version of java than is required by opentelemetry-java?
There was a problem hiding this comment.
interesting, i'm guessing it didn't spit out a useful error to give us any clues?
There was a problem hiding this comment.
Was testing this on my fork. Here's the build out put without setting up java: https://github.com/jack-berg/opentelemetry-java/actions/runs/5204819774/jobs/9389527088
There was a problem hiding this comment.
Ya I think we're good to remove
Commented on wrong thread
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #5511 +/- ##
=========================================
Coverage 91.34% 91.34%
Complexity 4957 4957
=========================================
Files 550 550
Lines 14543 14543
Branches 1359 1359
=========================================
Hits 13285 13285
Misses 872 872
Partials 386 386 ☔ View full report in Codecov by Sentry. |
| uses: actions/setup-java@v3 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 |
There was a problem hiding this comment.
interesting, i'm guessing it didn't spit out a useful error to give us any clues?
…y-java into autoupdate-gradle-wrapper
No description provided.