Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new TLS related APIs on Jaeger buiders. #5422

Merged
merged 1 commit into from
May 5, 2023
Merged

Add new TLS related APIs on Jaeger buiders. #5422

merged 1 commit into from
May 5, 2023

Conversation

chicobento
Copy link
Contributor

Relates to comment #5280 (comment)

@chicobento chicobento requested a review from a team May 4, 2023 19:08
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (23c5516) 91.27% compared to head (977a7fc) 91.27%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5422   +/-   ##
=========================================
  Coverage     91.27%   91.27%           
- Complexity     4888     4890    +2     
=========================================
  Files           549      549           
  Lines         14402    14406    +4     
  Branches       1354     1354           
=========================================
+ Hits          13145    13149    +4     
  Misses          869      869           
  Partials        388      388           
Impacted Files Coverage Δ
...exporter/jaeger/JaegerGrpcSpanExporterBuilder.java 81.81% <100.00%> (+1.17%) ⬆️
...ace/jaeger/sampler/JaegerRemoteSamplerBuilder.java 98.21% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chicobento
Copy link
Contributor Author

hi @jack-berg , do you think this could reviewed on time for 1.26 ?

@jack-berg
Copy link
Member

Are you waiting on this in particular?

@chicobento
Copy link
Contributor Author

yeap, specially the changes on JaegerRemoteSamplerBuilder - would like to migrate to the byo strategy in one shot

@jack-berg
Copy link
Member

I think we can get this in. @jkwatson what do you think?

@jack-berg
Copy link
Member

@open-telemetry/java-approvers PTAL.

@jack-berg jack-berg merged commit db8ade3 into open-telemetry:main May 5, 2023
@chicobento chicobento deleted the ssl_context_jaeger branch May 5, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants