Log Bridge API / SDK cleanup #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
May 4, 2023
| @@ -3,7 +3,7 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| package io.opentelemetry.sdk.logs; | |||
| package io.opentelemetry.sdk.logs.internal; | |||
There was a problem hiding this comment.
In #5341 I propose we move SdkEventEmitterProvder to an internal package rather than splitting out into a separate module. We should make the move before the release so the only change in the next release is marking the module as stable.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #5420 +/- ##
=========================================
Coverage 91.29% 91.29%
- Complexity 4888 4889 +1
=========================================
Files 549 549
Lines 14402 14402
Branches 1354 1354
=========================================
+ Hits 13148 13149 +1
Misses 867 867
+ Partials 387 386 -1
☔ View full report in Codecov by Sentry. |
mateuszrzeszutek
approved these changes
May 5, 2023
trask
approved these changes
May 5, 2023
breedx-splk
approved these changes
May 5, 2023
jkwatson
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a final pass on the Log Bridge API / SDK since we're treating the next release as a RC. Noticed a few minor things to tighten up.