Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for metrics name to prevent add duplicated _total suffix #5308

Merged

Conversation

ShadowySpirits
Copy link
Contributor

fix #5304

@ShadowySpirits ShadowySpirits requested a review from a team March 17, 2023 02:21
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 17, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ShadowySpirits / name: SSpirits (adbf815)

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40 🎉

Comparison is base (3d5424a) 90.97% compared to head (2640d81) 91.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5308      +/-   ##
============================================
+ Coverage     90.97%   91.37%   +0.40%     
- Complexity     4907     5204     +297     
============================================
  Files           552      556       +4     
  Lines         14489    15533    +1044     
  Branches       1372     1493     +121     
============================================
+ Hits          13182    14194    +1012     
- Misses          907      934      +27     
- Partials        400      405       +5     
Impacted Files Coverage Δ
.../opentelemetry/exporter/prometheus/Serializer.java 86.68% <100.00%> (ø)

... and 51 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 31, 2023
@github-actions
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Apr 14, 2023
@jack-berg jack-berg reopened this Apr 26, 2023
@jack-berg jack-berg merged commit 6ba5919 into open-telemetry:main May 2, 2023
@ShadowySpirits ShadowySpirits deleted the fix_prometheus_exporter branch May 2, 2023 15:12
@jack-berg jack-berg mentioned this pull request May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus exporter add duplicated suffix for counter metrics
2 participants