docs(readme): fix resource providers property docs #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we can see in https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java#L45 and also in open-telemetry#3240, the name of the enable/disable resource providers ends with `resource.providers`, not `resource-providers`.
Codecov ReportBase: 91.10% // Head: 91.10% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #5135 +/- ##
=========================================
Coverage 91.10% 91.10%
Complexity 4901 4901
=========================================
Files 549 549
Lines 14497 14497
Branches 1390 1390
=========================================
Hits 13208 13208
Misses 890 890
Partials 399 399 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
breedx-splk
approved these changes
Jan 18, 2023
jkwatson
approved these changes
Jan 21, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Anything else missing to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can see in https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/ResourceConfiguration.java#L45 and also in #3240, the name of the enable/disable resource providers ends with
resource.providers, notresource-providers.