Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper shutdown implementations for all exporters #5113

Merged
merged 1 commit into from
Jan 14, 2023

Conversation

jack-berg
Copy link
Member

Add proper shutdown implementation to all the exporters:

  • Shutting down multiple times logs a warning
  • Calling export after shutdown returns CompletableResultCode.ofFailure() and skips export

@jack-berg jack-berg requested a review from a team January 11, 2023 17:18
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 91.05% // Head: 91.11% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (fa47019) compared to base (b300e72).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5113      +/-   ##
============================================
+ Coverage     91.05%   91.11%   +0.05%     
- Complexity     4886     4914      +28     
============================================
  Files           551      551              
  Lines         14462    14524      +62     
  Branches       1390     1390              
============================================
+ Hits          13169    13233      +64     
+ Misses          894      891       -3     
- Partials        399      400       +1     
Impacted Files Coverage Δ
...etry/exporter/prometheus/PrometheusHttpServer.java 80.73% <ø> (ø)
...try/exporter/internal/grpc/OkHttpGrpcExporter.java 82.00% <100.00%> (+1.14%) ⬆️
...y/exporter/internal/grpc/UpstreamGrpcExporter.java 91.30% <100.00%> (+1.06%) ⬆️
...metry/exporter/internal/okhttp/OkHttpExporter.java 90.14% <100.00%> (+0.74%) ⬆️
...porter/jaeger/thrift/JaegerThriftSpanExporter.java 81.13% <100.00%> (+7.13%) ⬆️
...logging/otlp/OtlpJsonLoggingLogRecordExporter.java 85.71% <100.00%> (+5.71%) ⬆️
...er/logging/otlp/OtlpJsonLoggingMetricExporter.java 88.46% <100.00%> (+2.74%) ⬆️
...rter/logging/otlp/OtlpJsonLoggingSpanExporter.java 90.90% <100.00%> (+3.40%) ⬆️
...emetry/exporter/logging/LoggingMetricExporter.java 82.75% <100.00%> (+3.59%) ⬆️
...elemetry/exporter/logging/LoggingSpanExporter.java 95.12% <100.00%> (+0.83%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkwatson jkwatson merged commit e82ab27 into open-telemetry:main Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants