Minimize public surface area of OpenTracingShim #5110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4911. Trimming down the public API surface area of OpenTracingShim.
OpenTracingShim contains several different factory methods allowing users to create Tracer shims using various combinations of
GlobalOpenTelemetry
,OpenTelemetry
,TracerProvider
, andTracer
. Simplified to just two methods, which becomes the total public API surface area of the entire module:If a user wants to use the global, just call
createTracerShim(GlobalOpenTelemetry.get())
.This allows the removal of
OpenTracingPropagators
andOpenTracingPropagatorsBuilder
, which was just a wrapper for a TextMapPropagator and http TextMapPropagator.cc @carlosalberto