Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LoggerBuilder, MeterBuilder, TracerBuilder javadoc #5050

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

jack-berg
Copy link
Member

#4711 was closed because we haven't had demand for scope attributes yet, but it included some useful javadoc clarifications in LoggerBuilder, MeterBuilder, and TracerBuilder that I think are worth retaining.

@jack-berg jack-berg requested a review from a team December 16, 2022 21:28
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 91.25% // Head: 91.25% // No change to project coverage 👍

Coverage data is based on head (a2b60d0) compared to base (57595b0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5050   +/-   ##
=========================================
  Coverage     91.25%   91.25%           
  Complexity     4894     4894           
=========================================
  Files           552      552           
  Lines         14481    14481           
  Branches       1386     1386           
=========================================
  Hits          13214    13214           
  Misses          878      878           
  Partials        389      389           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkwatson jkwatson merged commit 34f2601 into open-telemetry:main Dec 17, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants