Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge otlp grpc trace and metric exporter into :exporters:otlp:all #4494

Merged
merged 1 commit into from
May 27, 2022

Conversation

jack-berg
Copy link
Member

Related to #4482.

If approved I'd like to do the same otlp http by merging :exporters:otlp-http:trace and :exporters:otlp-http:metrics into a new module called :exporters:otlp-http:all.

@jack-berg jack-berg requested a review from a user May 25, 2022 20:40
@jack-berg jack-berg requested a review from Oberon00 as a code owner May 25, 2022 20:40
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #4494 (ad2dd6b) into main (de824dc) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4494   +/-   ##
=========================================
  Coverage     90.02%   90.02%           
  Complexity     5034     5034           
=========================================
  Files           578      578           
  Lines         15536    15536           
  Branches       1494     1494           
=========================================
  Hits          13987    13987           
  Misses         1089     1089           
  Partials        460      460           
Impacted Files Coverage Δ
...ter/otlp/metrics/ExportMetricsServiceResponse.java 100.00% <ø> (ø)
...rter/otlp/metrics/MarshalerMetricsServiceGrpc.java 90.47% <ø> (ø)
.../exporter/otlp/metrics/OtlpGrpcMetricExporter.java 81.81% <ø> (ø)
...er/otlp/metrics/OtlpGrpcMetricExporterBuilder.java 94.44% <ø> (ø)
...xporter/otlp/trace/ExportTraceServiceResponse.java 100.00% <ø> (ø)
...exporter/otlp/trace/MarshalerTraceServiceGrpc.java 90.47% <ø> (ø)
...etry/exporter/otlp/trace/OtlpGrpcSpanExporter.java 77.77% <ø> (ø)
...porter/otlp/trace/OtlpGrpcSpanExporterBuilder.java 93.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de824dc...ad2dd6b. Read the comment docs.

@anuraaga
Copy link
Contributor

This seems reasonable to me, it's a tiny amount of code in each artifact. What do you think of merging the HTTP exporters into this same artifact too?

@jack-berg
Copy link
Member Author

Was planning on doing a separate artifact for the http exporters, but come to think of it, both grpc and the http versions depend on okhttp, and share the same serialization code, so why not?

@jack-berg jack-berg merged commit 60cc5f4 into open-telemetry:main May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants