Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resource setter and getter from Tracer #387

Merged

Conversation

pavolloffay
Copy link
Member

Supersedes #352

Signed-off-by: Pavol Loffay [email protected]

@codecov-io
Copy link

Codecov Report

Merging #387 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #387      +/-   ##
============================================
+ Coverage     64.58%   64.78%   +0.19%     
  Complexity      347      347              
============================================
  Files            57       57              
  Lines          1316     1312       -4     
  Branches        118      118              
============================================
  Hits            850      850              
+ Misses          423      419       -4     
  Partials         43       43
Impacted Files Coverage Δ Complexity Δ
...ain/java/io/opentelemetry/sdk/trace/TracerSdk.java 46.15% <ø> (+6.15%) 5 <0> (ø) ⬇️
...ain/java/io/opentelemetry/trace/DefaultTracer.java 71.79% <ø> (+3.5%) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfdeef...5148c96. Read the comment docs.

@bogdandrutu bogdandrutu merged commit c62fe50 into open-telemetry:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants