Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Gradle 7.2 #3572

Merged
merged 2 commits into from
Sep 2, 2021
Merged

Update to Gradle 7.2 #3572

merged 2 commits into from
Sep 2, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Sep 1, 2021

And try ubuntu-20.04.

@jkwatson I tried incorporating #3568 into this to see how it goes, mainly since I know it won't use the build cache at all.

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #3572 (f46dc37) into main (3c1c863) will increase coverage by 89.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3572       +/-   ##
===========================================
+ Coverage        0   89.30%   +89.30%     
- Complexity      0     3478     +3478     
===========================================
  Files           0      384      +384     
  Lines           0    11419    +11419     
  Branches        0     1135     +1135     
===========================================
+ Hits            0    10198    +10198     
- Misses          0      854      +854     
- Partials        0      367      +367     
Impacted Files Coverage Δ
...pentelemetry/api/baggage/BaggageEntryMetadata.java 100.00% <0.00%> (ø)
.../opentelemetry/sdk/metrics/data/LongPointData.java 100.00% <0.00%> (ø)
...emetry/sdk/metrics/internal/view/ViewRegistry.java 75.00% <0.00%> (ø)
...ry/sdk/metrics/internal/aggregator/Aggregator.java 0.00% <0.00%> (ø)
...rter/otlp/metrics/MarshalerMetricsServiceGrpc.java 88.00% <0.00%> (ø)
...ry/sdk/trace/export/BatchSpanProcessorBuilder.java 96.55% <0.00%> (ø)
...a/io/opentelemetry/sdk/metrics/SdkLongCounter.java 100.00% <0.00%> (ø)
...ry/sdk/metrics/internal/view/StringPredicates.java 50.00% <0.00%> (ø)
.../propagation/B3PropagatorInjectorSingleHeader.java 100.00% <0.00%> (ø)
...io/opentelemetry/context/ImplicitContextKeyed.java 100.00% <0.00%> (ø)
... and 374 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1c863...f46dc37. Read the comment docs.

private static final Set<String> BLOCKED_PROPERTIES = new HashSet<>();

static {
BLOCKED_PROPERTIES.add("java.home");
Copy link
Contributor Author

@anuraaga anuraaga Sep 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a failure on this PR (caused by ubuntu? never saw it before but it seems like some random flakiness) where JUL is initialized within this security manager context, and JUL reads a property.

More smartness for managing these properties came to mind, for example a class that contains them as constants and by convention always add to that class. Didn't seem worth it for now though.

@jkwatson
Copy link
Contributor

jkwatson commented Sep 1, 2021

I want to merge this, but github isn't letting me change the branch protection rules to include the 20.04 entries. It let me do it yesterday, but it can't see the checks today. 🤔

@anuraaga
Copy link
Contributor Author

anuraaga commented Sep 2, 2021

@jkwatson Hmm can confirm I don't see them either. Manually editing the DOM in Chrome inspector didn't work either 😂

@jkwatson
Copy link
Contributor

jkwatson commented Sep 2, 2021

@jkwatson Hmm can confirm I don't see them either. Manually editing the DOM in Chrome inspector didn't work either 😂

I wonder if merging this might force the issue. We can always manually merge after checking what's passed until that bug is fixed.

@anuraaga
Copy link
Contributor Author

anuraaga commented Sep 2, 2021

I wonder if merging this might force the issue. We can always manually merge after checking what's passed until that bug is fixed.

Yeah I had that thought to. Let's try it

@anuraaga anuraaga merged commit 29cc44e into open-telemetry:main Sep 2, 2021
@anuraaga
Copy link
Contributor Author

anuraaga commented Sep 2, 2021

@jkwatson I went ahead and removed the required status check on ubuntu-18.04. And now that can't be restored, searching in the checks only shows Build (macos-*). The GitHub bug appears to be something like only items that are already in the list are presented in the autocompletion...

@jkwatson
Copy link
Contributor

jkwatson commented Sep 2, 2021

Ugh. A little more work for us until that gets fixed. Has anyone logged it with github yet?

This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants