-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 7.2 #3572
Update to Gradle 7.2 #3572
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3572 +/- ##
===========================================
+ Coverage 0 89.30% +89.30%
- Complexity 0 3478 +3478
===========================================
Files 0 384 +384
Lines 0 11419 +11419
Branches 0 1135 +1135
===========================================
+ Hits 0 10198 +10198
- Misses 0 854 +854
- Partials 0 367 +367
Continue to review full report at Codecov.
|
private static final Set<String> BLOCKED_PROPERTIES = new HashSet<>(); | ||
|
||
static { | ||
BLOCKED_PROPERTIES.add("java.home"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a failure on this PR (caused by ubuntu? never saw it before but it seems like some random flakiness) where JUL is initialized within this security manager context, and JUL reads a property.
More smartness for managing these properties came to mind, for example a class that contains them as constants and by convention always add to that class. Didn't seem worth it for now though.
I want to merge this, but github isn't letting me change the branch protection rules to include the 20.04 entries. It let me do it yesterday, but it can't see the checks today. 🤔 |
@jkwatson Hmm can confirm I don't see them either. Manually editing the DOM in Chrome inspector didn't work either 😂 |
I wonder if merging this might force the issue. We can always manually merge after checking what's passed until that bug is fixed. |
Yeah I had that thought to. Let's try it |
@jkwatson I went ahead and removed the required status check on ubuntu-18.04. And now that can't be restored, searching in the checks only shows Build (macos-*). The GitHub bug appears to be something like only items that are already in the list are presented in the autocompletion... |
Ugh. A little more work for us until that gets fixed. Has anyone logged it with github yet? |
And try ubuntu-20.04.
@jkwatson I tried incorporating #3568 into this to see how it goes, mainly since I know it won't use the build cache at all.