Separate out autoconfigure-spi artifact with tracing autoconfiguratio… #3570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
arminru,
bogdandrutu,
carlosalberto and
jkwatson
as code owners
anuraaga
requested review from
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
anuraaga
commented
Aug 31, 2021
| ***! MODIFIED CLASS: PUBLIC FINAL io.opentelemetry.extension.trace.propagation.B3ConfigurablePropagator (not serializable) |
There was a problem hiding this comment.
Oops - sorry I didn't run a full build on the previous PR
|
I'm not an expert, but I thought the Java module system would blow up if two modules tried to export the same package and were being loaded by the same classloader, which these would, I think. :( |
|
Since we're breaking all of this, we could have |
|
Split up, it seems good and does solve the JMS problem. |
jsuereth
approved these changes
Sep 1, 2021
jsuereth
pushed a commit
to jsuereth/opentelemetry-java
that referenced
this pull request
Sep 2, 2021
open-telemetry#3570) * Separate out autoconfigure-spi artifact with tracing autoconfiguration SPI. * Split
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n SPI.
I have not marked this artifact as alpha since I think it's ready to roll.
It means the same package is in both autoconfigure-spi and autoconfigure - this may cause JMS issues, but I'm not sure it's a big deal while metrics is alpha. If someone knows it is, I'd probably need to temporarily name the metrics SPIs package
autoconfigure.spi.alpha