Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use autoconfigure SPI for trace-propagators extension. #3294

Merged
merged 2 commits into from
Jun 8, 2021

Conversation

anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Jun 7, 2021

While I'm not exactly sure what @kenfinnigan will do with them, if there's a use case I don't see anything wrong with this since the autoconfigure dep isn't leaked at all.

#3284

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Less "manual" configuration code is always better.

@kenfinnigan
Copy link
Member

Thanks @anuraaga, looks great.

The only comment is based on what you asked in my original question, about whether the SPI should be a separate artifact. Ideally, it would be separate, but it's not a showstopper.

@anuraaga
Copy link
Contributor Author

anuraaga commented Jun 7, 2021

Thanks @kenfinnigan I think splitting SPI makes sense and is consistent with auto instrumentation too. Will look at it in another PR.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, especially since it doesn't impact using the propagators directly without autoconfigure around.

@jkwatson
Copy link
Contributor

jkwatson commented Jun 7, 2021

Nice. Less "manual" configuration code is always better.

As long as we don't lose sight of the fact that there are 100% manual configuration use-cases that we must always support as well.

Copy link
Member

@kenfinnigan kenfinnigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @anuraaga!

@anuraaga anuraaga merged commit 39ec5ba into open-telemetry:main Jun 8, 2021
@jkwatson
Copy link
Contributor

jkwatson commented Jun 8, 2021

@anuraaga looks like this didn't include the apidiffs changes introduced by this. I'll add it to my CHANGELOG updates before release.

This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants