Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the baggage API fully functional in the API #1822

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

jkwatson
Copy link
Contributor

@jkwatson jkwatson commented Oct 16, 2020

and get rid of the BaggageManager that was needed previously.

This moves the Baggage implementation to the API, per open-telemetry/opentelemetry-specification#1103, which is now merged.

I could split this up, if desired, into 2 parts:

  1. Move the implementation to the API, remove it from the SDK, but keep the BaggageManager in place.
  2. Remove the BaggageManager entirely.

@codecov
Copy link

codecov bot commented Oct 16, 2020

Codecov Report

Merging #1822 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1822      +/-   ##
============================================
+ Coverage     85.47%   85.58%   +0.11%     
+ Complexity     1448     1434      -14     
============================================
  Files           177      174       -3     
  Lines          5589     5556      -33     
  Branches        580      579       -1     
============================================
- Hits           4777     4755      -22     
+ Misses          612      601      -11     
  Partials        200      200              
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/io/opentelemetry/OpenTelemetry.java 97.91% <ø> (-0.24%) 20.00 <0.00> (-2.00)
.../opentelemetry/opentracingshim/BaseShimObject.java 100.00% <ø> (ø) 5.00 <0.00> (-1.00)
...in/java/io/opentelemetry/sdk/OpenTelemetrySdk.java 100.00% <ø> (ø) 2.00 <0.00> (-1.00)
...rc/main/java/io/opentelemetry/baggage/Baggage.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...in/java/io/opentelemetry/baggage/BaggageUtils.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...ava/io/opentelemetry/baggage/ImmutableBaggage.java 96.49% <100.00%> (ø) 16.00 <4.00> (?)
...etry/baggage/propagation/W3CBaggagePropagator.java 93.18% <100.00%> (-0.44%) 15.00 <0.00> (ø)
...opentelemetry/opentracingshim/SpanContextShim.java 88.57% <100.00%> (ø) 9.00 <0.00> (ø)
...o/opentelemetry/opentracingshim/TelemetryInfo.java 100.00% <100.00%> (ø) 5.00 <1.00> (-1.00)
...va/io/opentelemetry/opentracingshim/TraceShim.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9efb503...b50ce5c. Read the comment docs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just one point about visibility - presume since we have an interface, we don't need to make the implementation of baggage public

* @throws IllegalStateException if a specified manager (via system properties) could not be
* found.
*/
public static BaggageManager getBaggageManager() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@anuraaga
Copy link
Contributor

Thanks! Can you rebase to get the build fix?

@jkwatson jkwatson merged commit e13e631 into open-telemetry:master Oct 21, 2020
@jkwatson jkwatson deleted the baggage_in_the_api branch October 21, 2020 04:57
@carlosalberto
Copy link
Contributor

Late review, thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants