Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the RETRYABLE failure mode from the exporter interfaces. #1112

Merged

Conversation

jkwatson
Copy link
Contributor

With the merging of open-telemetry/opentelemetry-specification#511, this should get us into spec compliance.

@codecov-io
Copy link

Codecov Report

Merging #1112 into master will increase coverage by 0.14%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1112      +/-   ##
============================================
+ Coverage     85.58%   85.73%   +0.14%     
+ Complexity     1085     1081       -4     
============================================
  Files           138      138              
  Lines          3990     3974      -16     
  Branches        355      351       -4     
============================================
- Hits           3415     3407       -8     
+ Misses          434      426       -8     
  Partials        141      141              
Impacted Files Coverage Δ Complexity Δ
...metry/exporters/jaeger/JaegerGrpcSpanExporter.java 63.23% <0.00%> (+3.51%) 4.00 <0.00> (ø)
...metry/exporters/inmemory/InMemorySpanExporter.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...lemetry/exporters/otlp/OtlpGrpcMetricExporter.java 82.75% <100.00%> (+3.97%) 5.00 <0.00> (-1.00) ⬆️
...telemetry/exporters/otlp/OtlpGrpcSpanExporter.java 82.75% <100.00%> (+3.97%) 5.00 <0.00> (-1.00) ⬆️
...entelemetry/sdk/metrics/export/MetricExporter.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ntelemetry/sdk/trace/export/MultiSpanExporter.java 100.00% <100.00%> (ø) 10.00 <0.00> (-2.00)
...o/opentelemetry/sdk/trace/export/SpanExporter.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 848461d...28c650a. Read the comment docs.

@carlosalberto carlosalberto merged commit adf82e7 into open-telemetry:master Apr 14, 2020
davebarda pushed a commit to davebarda/opentelemetry-java that referenced this pull request Apr 24, 2020
@jkwatson jkwatson added this to the May Release milestone May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants