Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider creating metrics for dropped span information #766

Open
jkwatson opened this issue Jan 17, 2020 · 1 comment
Open

Consider creating metrics for dropped span information #766

jkwatson opened this issue Jan 17, 2020 · 1 comment
Labels
release:after-ga

Comments

@jkwatson
Copy link
Contributor

Links, attributes and events all have a maximum. If it is exceeded, we'll start dropping data. We should consider incrementing OTel counters when we do so.
@jkwatson jkwatson mentioned this issue Jan 17, 2020
Merged
jkwatson pushed a commit to newrelic-forks/opentelemetry-java that referenced this issue Jan 17, 2020
remove the todo; replaced with open-telemetry#766
5f208b8
@arminru
Copy link
Member

arminru commented Jan 17, 2020

see also:

opentelemetry-java/sdk/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpansProcessor.java

Lines 274 to 278 in ba17e1f

if (spansList.size() == maxQueueSize) {
// TODO: Record a counter for dropped spans.
return;
}
// TODO: Record a gauge for referenced spans.

bogdandrutu pushed a commit that referenced this issue Jan 17, 2020
@jkwatson @bogdandrutu
Optimize SpanBuilderSdk link memory (#753)
564a323 
* ignore links beyond the limit, rather than waiting until the end to truncate on span creation.

* update for changes from upstream

* remove the todo; replaced with #766
@jkwatson jkwatson mentioned this issue Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release:after-ga
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkwatson @arminru