Skip to content

Commit

Permalink
Update semconv to 1.18.0 (#5188)
Browse files Browse the repository at this point in the history
  • Loading branch information
jack-berg authored Feb 9, 2023
1 parent 2b7fe75 commit 358ad6c
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 3 deletions.
2 changes: 1 addition & 1 deletion buildscripts/semantic-convention/generate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
ROOT_DIR="${SCRIPT_DIR}/../../"

# freeze the spec & generator tools versions to make SemanticAttributes generation reproducible
SEMCONV_VERSION=1.17.0
SEMCONV_VERSION=1.18.0
SPEC_VERSION=v$SEMCONV_VERSION
SCHEMA_URL=https://opentelemetry.io/schemas/$SEMCONV_VERSION
GENERATOR_VERSION=0.14.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -276,5 +276,16 @@ public final class {{class}} {

{% endif %}

{%- if class == "ResourceAttributes" %}

/**
* Red Hat OpenShift on Google Cloud.
* @deprecated This item has been removed as of 1.18.0 of the semantic conventions. Use {@link ResourceAttributes#GCP_OPENSHIFT} instead.
*/
@Deprecated
public static final String GCP_OPENSHIFT = "gcp_openshift";

{% endif %}

private {{class}}() {}
}
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
@SuppressWarnings("unused")
public final class ResourceAttributes {
/** The URL of the OpenTelemetry schema for these keys and values. */
public static final String SCHEMA_URL = "https://opentelemetry.io/schemas/1.17.0";
public static final String SCHEMA_URL = "https://opentelemetry.io/schemas/1.18.0";

/**
* Array of brand name and version separated by a space
Expand Down Expand Up @@ -728,7 +728,7 @@ public static final class CloudPlatformValues {
/** Google Cloud App Engine (GAE). */
public static final String GCP_APP_ENGINE = "gcp_app_engine";
/** Red Hat OpenShift on Google Cloud. */
public static final String GOOGLE_CLOUD_OPENSHIFT = "google_cloud_openshift";
public static final String GCP_OPENSHIFT = "gcp_openshift";
/** Red Hat OpenShift on IBM Cloud. */
public static final String IBM_CLOUD_OPENSHIFT = "ibm_cloud_openshift";
/** Tencent Cloud Cloud Virtual Machine (CVM). */
Expand Down Expand Up @@ -825,5 +825,13 @@ public static final class TelemetrySdkLanguageValues {
private TelemetrySdkLanguageValues() {}
}

/**
* Red Hat OpenShift on Google Cloud.
*
* @deprecated This item has been removed as of 1.18.0 of the semantic conventions. Use {@link
* ResourceAttributes#GCP_OPENSHIFT} instead.
*/
@Deprecated public static final String GCP_OPENSHIFT = "gcp_openshift";

private ResourceAttributes() {}
}

0 comments on commit 358ad6c

Please sign in to comment.