Rewrite @Advice.Enter for indy advice #9887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Nov 16, 2023
...src/main/java/io/opentelemetry/javaagent/tooling/instrumentation/indy/AdviceTransformer.java
Show resolved
Hide resolved
laurit
force-pushed
the
indy-rewrite-advice-enter
branch
from
0fe2dcb to
30e9ef0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite entry advice that doesn't return
voidby embedding the original return value inObjectarray that we use to carry the locals etc from enter to exit advice. This also resolves the issue where using helper class as a return value from entry advice didn't work because helper classes aren't visible to the advised class (now it seesObject[]instead of the helper).