Jvm stable threads #9839
Merged
Jvm stable threads #9839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
jvm-stable-threads
branch
from
3e24761 to
b59395d
Compare
jack-berg
approved these changes
Nov 14, 2023
| @@ -47,22 +64,94 @@ public static List<AutoCloseable> registerObservers(OpenTelemetry openTelemetry) | |||
| List<AutoCloseable> registerObservers(OpenTelemetry openTelemetry, ThreadMXBean threadBean) { | |||
| Meter meter = JmxRuntimeMetricsUtil.getMeter(openTelemetry); | |||
There was a problem hiding this comment.
At some point we'll want to update the scope to include the schemaUrl of the semantic conventions this follows.
There was a problem hiding this comment.
I'm guessing we're gonna do that once the JVM spec is stabilized.
...va8/library/src/main/java/io/opentelemetry/instrumentation/runtimemetrics/java8/Threads.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
force-pushed
the
jvm-stable-threads
branch
3 times, most recently
from
6be4a48 to
7bc412b
Compare
mateuszrzeszutek
force-pushed
the
jvm-stable-threads
branch
from
7bc412b to
3e54e14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #9821 to be merged first
I brought back the implementation from #7636