-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress instrumentation based on suppress Context key #9739
Suppress instrumentation based on suppress Context key #9739
Conversation
Hi @jack-berg - If I understood correctly, these should be the changes we were talking about in last week's SIG. We will need to use a Context key defined in the OTel Java repo though, so I guess these changes would have to wait for a new release there that contains these changes. Please let me know if there's anything we should improve here or in the core repo's PR! |
...ion-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/SpanSuppressors.java
Outdated
Show resolved
Hide resolved
I'm not quite sure what the CI issue related to |
@LikeTheSalad latest dep tests can start failing when there is a new version of tested library. They are not required for merging but you could get them passing by rebasing your pr. |
|
||
ByContextKey(SpanSuppressor delegate) { | ||
this.delegate = delegate; | ||
Method shouldSuppressInstrumentation; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad Android desugaring doesn't support MethodHandle
s 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ikr 😩
An approach to suppress automatic instrumentations based on the suppress_instrumentation Context key.