Generate only consumer span for sqs receive message #9652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Oct 11, 2023
| if (Context.root() == parentContext | ||
| && "com.amazonaws.services.sqs.model.ReceiveMessageRequest" | ||
| .equals(request.getOriginalRequest().getClass().getName())) { | ||
| Context context = InstrumenterUtil.suppressSpan(requestInstrumenter, parentContext, request); |
There was a problem hiding this comment.
This is another good case for the suppressSpan flag mentioned in open-telemetry/opentelemetry-java#5886
For not this hack is probably fine though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently sqs instrumentation generates two spans named
SQS.ReceiveMessage. One is the consumer span that is in the same trace as the producer. The other is the rpc/http client span that is in a separate trace, this span is responsible of suppressing the underlying http client instrumentation. This pr skips creating the rpc/http span if there is no parent trace and no error. When there is no parent trace this span would be in its own trace which is not connected to the trace with the messaging spans.