Add HTTP server tests for non standard methods #9446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
force-pushed
the
http-server-non-standard
branch
from
293bf8e to
ba2afa8
Compare
laurit
reviewed
Sep 12, 2023
...src/main/java/io/opentelemetry/instrumentation/testing/junit/http/HttpServerTestOptions.java
Outdated
Show resolved
Hide resolved
laurit
approved these changes
Sep 12, 2023
mateuszrzeszutek
force-pushed
the
http-server-non-standard
branch
from
1f509fd to
97d9602
Compare
mateuszrzeszutek
force-pushed
the
http-server-non-standard
branch
from
97d9602 to
507ad2f
Compare
| * Returns a new {@link HttpServerRouteBuilder} that can be used to configure the {@link | ||
| * HttpServerRoute}. | ||
| */ | ||
| public static <REQUEST> HttpServerRouteBuilder<REQUEST> builder( |
There was a problem hiding this comment.
I had to add a builder for the HttpServerRoute as well, because it updates the span name.
I'm starting to think that this may be kind of cumbersome for the users, if you want to use custom knownMethods you have to set it in 3 different builders. What if we had some Http(Server|Client)Semconv class that has just one builder, and provides facrory methods for all the instrumenter parts? Just an idea for future PRs.
There was a problem hiding this comment.
it does seem really easy to miss that you need to set knownMethod in all 3 of those places...
samwright
added a commit
to annotell/opentelemetry-java-instrumentation
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8951