Ensure kafka configuration remains serializable #7754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszrzeszutek
approved these changes
Feb 7, 2023
trask
reviewed
Feb 8, 2023
| @@ -75,7 +76,8 @@ public static void enhanceConfig(Map<? super String, Object> config) { | |||
| OpenTelemetryMetricsReporter.class.getName(), | |||
| (class1, class2) -> class1 + "," + class2); | |||
| config.put( | |||
| OpenTelemetryMetricsReporter.CONFIG_KEY_OPENTELEMETRY_INSTANCE, GlobalOpenTelemetry.get()); | |||
| OpenTelemetryMetricsReporter.CONFIG_KEY_OPENTELEMETRY_SUPPLIER, | |||
| new OpenTelemetrySupplier(GlobalOpenTelemetry.get())); | |||
There was a problem hiding this comment.
can we use a supplier here that always returns GlobalOpenTelemetry.get()? that way it will "actually be serializable" in case that's a real thing for kafka config 🤷♂️
There was a problem hiding this comment.
There is also the library instrumentation where there is no way to restore the OpenTelemetry instance. I thought that we can let the reporter of this issue test it. If it is needed then he'll get a NPE and we'll know that we have to do something for both javaagent and library instrumentation.
trask
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7597
I wasn't able to reproduce this. Figuring out how to run beam, flink and kafka together feels like too much effort. Without reproducing it is too hard to tell why the configuration is serialized, but my hunch is that it is enough to ensure that the configuration can be serialized.