Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC request metadata instrumentation #7011
Add gRPC request metadata instrumentation #7011
Changes from 33 commits
c6f544b
7830c0f
045a616
33f2232
bc79e30
4c90987
5c302bb
cdd31b2
cf1649f
e0391fd
ae0783b
1b842ee
f8ed4e4
99e65a5
bd73355
1b14f73
5112050
3699771
577d98a
0809704
92e98ac
0135af8
80a8e69
ad399ce
095e7e9
50776df
a9122fd
1300621
e8ef646
45fa0e7
ba9cd2d
2801919
83d9a08
fcbae3c
a9d290c
5c75ecc
e2fbb6c
bb30c18
ffdb462
1b207c9
0026c0d
1ef28b6
23a8daf
6e42047
bea9394
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to capture attributes on start so they can be used for sampling?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trask Capture them only at start or at both start and end?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can they be different at those two times?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trask Not sure what you mean by that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I mean, if you capture the request metadata in onStart, is there a reason to capture them in onEnd also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trask So do you think it should only be on start?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we don't know of any reason to also be on end, then let's start with "only on start"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@trask
Status capture has to be on end because it doesn't exist at start.
I moved the metadata capture to start though