-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gradle to 7.5.1 #6359
Update gradle to 7.5.1 #6359
Conversation
fyi I bumped this to 7.5.1 just to see if that helped, but same error still |
mateuszrzeszutek#47 adds the |
@laurit WDYT about adding these JVM args to the |
@mateuszrzeszutek that is definitely an option. A potential benefit of not doing it would be that this could mask bugs in agent that cause it to fail without these arguments, but that doesn't seem like a big issue as we also have smoke tests that would take care of catching such issues. |
@laurit any idea why this only started to be a problem in gradle 7.5? |
@trask gradle used to add
by default, see gradle/gradle#19771 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like keeping the --add-opens
scoped to the instrumented library that needs them 👍
Gotcha. I'm merging this PR then, since I'm fine with both solutions. |
* Update gradle to 7.5 * Bump to 7.5.1 * gradle 7.5.1 with jdk17 * spotless * one more --add-opens Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]>
* Update gradle to 7.5 * Bump to 7.5.1 * gradle 7.5.1 with jdk17 * spotless * one more --add-opens Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]>
* Update gradle to 7.5 * Bump to 7.5.1 * gradle 7.5.1 with jdk17 * spotless * one more --add-opens Co-authored-by: Trask Stalnaker <[email protected]> Co-authored-by: Lauri Tulmin <[email protected]>
No description provided.