Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix flaky test by replacing list comparison with set comparison #480

Merged
merged 2 commits into from
Jun 8, 2020
Merged

Try to fix flaky test by replacing list comparison with set comparison #480

merged 2 commits into from
Jun 8, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Jun 8, 2020

Fixes #436

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 8, 2020 •
edited
Loading

CLA Check

@anuraaga anuraaga mentioned this pull request Jun 8, 2020
Merged
@iNikem iNikem force-pushed the tomcat-access-log-test branch from 867ceab to 0dc9e7f Compare June 8, 2020 07:43
trask
trask approved these changes Jun 8, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🤞🤞🤞

@iNikem iNikem merged commit 8ee5438 into open-telemetry:master Jun 8, 2020
@iNikem iNikem deleted the tomcat-access-log-test branch June 8, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sporadic test failure (12x): TomcatServlet3Test*
2 participants
@iNikem @trask