Allow overriding Span kind for AWS SDK v2. #464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
requested review from
iNikem,
jkwatson,
trask and
tylerbenson
as code owners
|
Getting a confusing unit test failure where it runs fine in isolation but not when run as part of the entire test class. Anyways, I realized I can work around this in the exporter instead of the instrumentation so will stick with that for now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interested in coming up with a potential general solution for layered client spans as in #440 and #460 but in the meantime, it'd be really helpful if there was a config option for the AWS span kind. We can deactivate the Apache HTTP instrumentation for now and it'd really unblock our work on getting the traces reported by the agent as close as possible to the normal X-Ray experience.