Remove cassandra db.name attribute #3199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
reviewed
Jun 6, 2021
| @@ -25,7 +26,10 @@ | |||
| protected void onStart(AttributesBuilder attributes, REQUEST request) { | |||
| set(attributes, SemanticAttributes.DB_SYSTEM, system(request)); | |||
| set(attributes, SemanticAttributes.DB_USER, user(request)); | |||
| set(attributes, SemanticAttributes.DB_NAME, name(request)); | |||
| AttributeKey<String> nameAttribute = dbNameAttribute(); | |||
There was a problem hiding this comment.
Hmm this weirdness seems like a good reason to go to the spec and remove the keyspace attribute? Not filling in a generic attribute seems like a bug, non-cassandra aware tracing systems would still get benefit from it.
There was a problem hiding this comment.
Definitely see where #2892 came from ;)
There was a problem hiding this comment.
👍 can I block my own PR? 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#cassandra: