Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent naming of addAttributesExtractor #12860

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

trask
Copy link
Member

@trask trask commented Dec 9, 2024

addAttributeExtractor methods in *TelemetryBuilder classes have been deprecated and renamed to addAttributesExtractor (which is how most of them were named already)

Part of #12846

See #12867 for change log migration notes entry

@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Dec 9, 2024
@trask trask force-pushed the add-attributes-extractor branch from 001cb25 to d9a79ca Compare December 9, 2024 05:36
@trask trask force-pushed the add-attributes-extractor branch from d9a79ca to 7b26f87 Compare December 9, 2024 05:53
@trask trask force-pushed the add-attributes-extractor branch from cd7d933 to 4c11036 Compare December 9, 2024 22:20
@trask trask marked this pull request as ready for review December 9, 2024 22:26
@trask trask requested a review from a team as a code owner December 9, 2024 22:26
@trask trask merged commit 4cc4e1c into open-telemetry:main Dec 10, 2024
56 checks passed
@trask trask deleted the add-attributes-extractor branch December 10, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants