Rename ktor tracing to ktor telemetry #12855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
12 tasks
trask
force-pushed
the
rename-ktor-tracing
branch
2 times, most recently
from
0ef7bb4 to
252db08
Compare
trask
commented
Dec 9, 2024
...ibrary/src/main/kotlin/io/opentelemetry/instrumentation/ktor/client/internal/Experimental.kt
Outdated
Show resolved
Hide resolved
trask
force-pushed
the
rename-ktor-tracing
branch
2 times, most recently
from
3defa4a to
f646ba2
Compare
trask
force-pushed
the
rename-ktor-tracing
branch
from
4f5c848 to
04d72e2
Compare
trask
force-pushed
the
rename-ktor-tracing
branch
from
8b7b2f3 to
2c08222
Compare
breedx-splk
approved these changes
Dec 10, 2024
breedx-splk
reviewed
Dec 10, 2024
...io/opentelemetry/instrumentation/ktor/v2_0/common/server/AbstractKtorServerTracingBuilder.kt
Show resolved
Hide resolved
trask
force-pushed
the
rename-ktor-tracing
branch
from
69a8841 to
9397547
Compare
laurit
reviewed
Dec 10, 2024
| fun setEmitExperimentalHttpClientMetrics(emitExperimentalHttpClientMetrics: Boolean) { | ||
| if (emitExperimentalHttpClientMetrics) { | ||
| emitExperimentalHttpClientMetrics() | ||
| } | ||
| } | ||
|
|
||
| @Deprecated("Please use method `Experimental.emitExperimentalHttpClientMetrics`") |
There was a problem hiding this comment.
I'm not sure this is needed as the class itself is deprecated. Also doesn't Experimental only work with the new telemetry builder class?
There was a problem hiding this comment.
I was trying to provide a hint where this method went since it's not obvious otherwise
laurit
reviewed
Dec 10, 2024
...ain/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/common/client/internal/Experimental.kt
Outdated
Show resolved
Hide resolved
laurit
reviewed
Dec 10, 2024
...ain/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/common/client/internal/Experimental.kt
Outdated
Show resolved
Hide resolved
trask
commented
Dec 12, 2024
Comment on lines
30
to
31
| internal lateinit var internalBuilder: DefaultHttpClientInstrumenterBuilder<HttpRequestData, HttpResponse> | ||
| protected lateinit var builder: DefaultHttpClientInstrumenterBuilder<HttpRequestData, HttpResponse> |
There was a problem hiding this comment.
I couldn't figure out how to have both internal and protected access
There was a problem hiding this comment.
internal should be enough -- is there a reason why it shouldn't be public? It can only be used by other classes in this module when it's internal. 👍🏻
There was a problem hiding this comment.
I found a better way than duplicating the field, I created an internal accessor to the protected field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*KtorClientTracing*and*KtorServerTracing*have been deprecated and renamed to*KtorClientTelemetry*and*KtorServerTelemetry*Also moves everthing under ktor-2-common into
*.v2_0.common.*packagePart of #12846
See #12867 for change log migration notes entry