Convert jaxrs tests to java #12816
Merged
Convert jaxrs tests to java #12816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaydeluca
reviewed
Nov 30, 2024
...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/v2_0/test/JaxRsTestResource.java
Outdated
Show resolved
Hide resolved
...agent/src/test/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/CxfFilterTest.java
Outdated
Show resolved
Hide resolved
...agent/src/test/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/CxfFilterTest.java
Outdated
Show resolved
Hide resolved
| protected void configure(HttpServerTestOptions options) { | ||
| super.configure(options); | ||
|
|
||
| options.setResponseCodeOnNonStandardHttpMethod(500); |
There was a problem hiding this comment.
the groovy test had a conditional to use 500 for testLatestDeps and 405 otherwise. I see you implemented that in the Jetty test, but that was not needed here as well? I assume not since the tests are all passing
There was a problem hiding this comment.
It is not needed because of using a lambda in
serverFactory.setProvider(
(ExceptionMapper<Exception>)
exception ->
Response.status(500)
.type(MediaType.TEXT_PLAIN_TYPE)
.entity(exception.getMessage())
.build());When choosing an exception mapper cxf inspects the exception mapper classes and ends up choosing between a built in mapper and our mapper. When using regular class it picks the built in one and when using lambda our one for the non standard http method test.
.../test/java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasyHttpServerTest.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/jaxrs/v2_0/ResteasyJettyHttpServerTest.java
Outdated
Show resolved
Hide resolved
...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/v3_0/test/JaxRsTestResource.java
Outdated
Show resolved
Hide resolved
.../java/io/opentelemetry/javaagent/instrumentation/jaxrs/v3_0/ResteasyJettyHttpServerTest.java
Outdated
Show resolved
Hide resolved
...on/testing/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsFilterTest.java
Outdated
Show resolved
Hide resolved
...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java
Outdated
Show resolved
Hide resolved
jaydeluca
approved these changes
Dec 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #7195