-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract APIGatewayProxyRequestEvent
headers for context propagation
#12440
Conversation
20d856c
to
e7569bd
Compare
- extract `APIGatewayProxyRequestEvent` headers for context propagation
e7569bd
to
4fd60f2
Compare
@cleverchuk could you update the PR title, we use PR titles in changelog. |
APIGatewayProxyRequestEvent
headers for context propagation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An additional unit test might be nice. Not sure how much effort that would be though.
@cleverchuk could you see if it is possible to build a test similar to that would test the functionality that you have implemented. |
- add test
@laurit @tylerbenson added a test. I don't understand entirely how the testing works though. However the test fails without the change, which I think is a good sign. This check kept failing so I removed it because I don't know how to get it to work. equalTo(HttpAttributes.HTTP_RESPONSE_STATUS_CODE, 201L) |
Thanks, I added the |
Extract
APIGatewayProxyRequestEvent
headers for context propagation. This change is only added toaws-lambda-events-2.2
package because theaws-lambda-core
instrumentation only applies to Lambdas that use custom events.