Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert all remaining database client decorators to tracers #1236

Merged
merged 9 commits into from
Sep 23, 2020
Merged

Convert all remaining database client decorators to tracers #1236

merged 9 commits into from
Sep 23, 2020

Conversation

iNikem
Copy link
Contributor

@iNikem iNikem commented Sep 22, 2020

No description provided.

@iNikem
Copy link
Contributor Author

iNikem commented Sep 22, 2020

Hm, @trask is it normal and expected that elasticsearch-transport-6.0.gradle limits testing to versions <6.5, but muzzle checks (and fails in this PR) even 7+?

trask
trask reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, lots of comments about pre-existing behavior, you can tell me to open issue(s) 😂

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/tracer/BaseTracer.java Show resolved Hide resolved
...rc/main/java/io/opentelemetry/instrumentation/auto/couchbase/v2_0/CouchbaseClientTracer.java Outdated Show resolved Hide resolved
...rc/main/java/io/opentelemetry/instrumentation/auto/couchbase/v2_0/CouchbaseClientTracer.java Outdated Show resolved Hide resolved
...rc/main/java/io/opentelemetry/instrumentation/auto/couchbase/v2_0/CouchbaseClientTracer.java Outdated Show resolved Hide resolved
...java/io/opentelemetry/instrumentation/auto/elasticsearch/rest/v5_0/RestResponseListener.java Outdated Show resolved Hide resolved
...n/hystrix-1.4/src/main/java/io/opentelemetry/instrumentation/auto/hystrix/HystrixTracer.java Outdated Show resolved Hide resolved
...rxjava-1.0/src/main/java/io/opentelemetry/instrumentation/auto/rxjava/TracedOnSubscribe.java Outdated Show resolved Hide resolved
...rxjava-1.0/src/main/java/io/opentelemetry/instrumentation/auto/rxjava/TracedOnSubscribe.java Show resolved Hide resolved
.../rxjava-1.0/src/main/java/io/opentelemetry/instrumentation/auto/rxjava/TracedSubscriber.java Outdated Show resolved Hide resolved
.../rxjava-1.0/src/main/java/io/opentelemetry/instrumentation/auto/rxjava/TracedSubscriber.java Outdated Show resolved Hide resolved
@trask
Copy link
Member

trask commented Sep 23, 2020

Hm, @trask is it normal and expected that elasticsearch-transport-6.0.gradle limits testing to versions <6.5, but muzzle checks (and fails in this PR) even 7+?

this is not unheard of 😂

a lot of times it's the test code that needs reworking from version to version, e.g. harness stuff as opposed to the underlying instrumentation

also see #749:

And sometimes the cap is needed because we haven't fixed the tests or the instrumentation to run on the latest version.

@iNikem
Copy link
Contributor Author

iNikem commented Sep 23, 2020

But if muzzle fails on later versions, should I then limit muzzle check range as well? And say that we don't actually support later versions?

trask
trask approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iNikem iNikem merged commit 85e2db8 into open-telemetry:master Sep 23, 2020
@iNikem iNikem deleted the database-client-tracers branch September 23, 2020 17:11
@iNikem iNikem mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trask trask trask approved these changes

@anuraaga anuraaga anuraaga approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iNikem @trask @anuraaga