Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capturing context in log4j library instrumentation with async logger #12176

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Sep 5, 2024

Resolves #11814
This PR makes appender instrumentation library depend on the context data instrumentation library. If context is not available when processing the log event (e.g. we are executing on a different thread than what initiated logging) we'll look into context data and reconstruct context from there if it is available.

@laurit laurit requested a review from a team September 5, 2024 08:11
@laurit laurit added this to the v2.8.0 milestone Sep 5, 2024
@trask trask merged commit e8c5c06 into open-telemetry:main Sep 12, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogRecord trace+span+flags are empty in case of Log4j2 async logging
4 participants