Review semantic convention for Http Client spans #1214
Conversation
iNikem
requested review from
anuraaga,
jkwatson,
trask and
tylerbenson
as code owners
| public static final boolean DEFAULT_LOG_INJECTION_ENABLED = false; | ||
| public static final String DEFAULT_EXPERIMENTAL_LOG_CAPTURE_THRESHOLD = null; |
| public static final String HTTP_SERVER_TAG_QUERY_STRING = "http.server.tag.query-string"; | ||
| public static final String HTTP_CLIENT_TAG_QUERY_STRING = "http.client.tag.query-string"; |
instrumentation/google-http-client-1.19/src/test/groovy/AbstractGoogleHttpClientTest.groovy
Outdated
Show resolved
Hide resolved
| @@ -52,4 +55,45 @@ abstract class JdkHttpClientTest extends HttpClientTest { | |||
| boolean testCircularRedirects() { | |||
| return false | |||
| } | |||
|
|
|||
| //We override this test below because it produces somewhat different attributes | |||
There was a problem hiding this comment.
is it only flavor that's different?
| SemanticAttributes.HTTP_FLAVOR.set( | ||
| span, httpResponse.version() == Version.HTTP_1_1 ? "1.1" : "2.0"); |
There was a problem hiding this comment.
interesting, makes sense for a negotiated connection, where we don't know flavor ahead of time
| @@ -46,6 +47,11 @@ protected String method(HttpRequest request) { | |||
| } | |||
| } | |||
|
|
|||
| @Override | |||
| protected @Nullable String flavor(HttpRequest httpRequest) { | |||
There was a problem hiding this comment.
I like this placement (type annotation) 👍
There was a problem hiding this comment.
I don't :) It is IDEA's doing, so I have to accept :(
There was a problem hiding this comment.
There was a problem hiding this comment.
Not reformat but "implement missing method", I think.
I don't want to fix this manually every time IDEA generates code for me. I can do it here, but it will not be sustainable
There was a problem hiding this comment.
ya, i like type annotations, but they are not common. i'm very surprised Intellij does the "right thing" 😉
…ctGoogleHttpClientTest.groovy Co-authored-by: Trask Stalnaker <[email protected]>
…p-client-convention
No description provided.