Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Influxdb indy support #11710

Merged
merged 22 commits into from
Aug 13, 2024
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
5aa65ea
Making influxdb advices indy friendly
LikeTheSalad Jun 28, 2024
736f58f
Returning original args when skipping the advice
LikeTheSalad Jun 28, 2024
47e3749
Re-adding enter advice suppress throwable
LikeTheSalad Jun 28, 2024
1307c57
Moving influxdb start/end logic to InfluxDbScope
LikeTheSalad Jun 28, 2024
e6b7869
Always updating calldepth
LikeTheSalad Jun 28, 2024
ba1e187
Decrementing calldepth for all advices
LikeTheSalad Jun 28, 2024
51aee44
Making InfluxDbInstrumentationModule indy
LikeTheSalad Jun 28, 2024
c6bbf1b
Adding javadoc to InfluxDbScope
LikeTheSalad Jul 1, 2024
0fd9346
Spotless
LikeTheSalad Jul 1, 2024
5af1195
Merge branch 'refs/heads/main' into influxdb-indy-support
LikeTheSalad Jul 1, 2024
0661d67
Enable @Advice.AssignReturned for non-indy Advices
JonasKunz Jun 13, 2024
73e1c13
Prevent advice transformations on advices already using @Advice.Assig…
JonasKunz Jun 24, 2024
3ffda00
Adjusting influxdb instrumentation to work as indy and not indy
LikeTheSalad Jul 2, 2024
30dbf5c
Spotless
LikeTheSalad Jul 2, 2024
c6a28cc
Merge branch 'refs/heads/main' into influxdb-indy-support
LikeTheSalad Aug 7, 2024
bfbb55d
Clean up after conflicts
LikeTheSalad Aug 7, 2024
f1121ec
Returning null when span isn't started
LikeTheSalad Aug 7, 2024
842749f
Returning InfluxDbScope instead of Object
LikeTheSalad Aug 7, 2024
71d6922
Applying PR suggestions on InfluxDbScope.end method and its usage
LikeTheSalad Aug 7, 2024
6e1dba7
Creating and calling helper method when instrumentation is only for d…
LikeTheSalad Aug 7, 2024
e454133
Spotless
LikeTheSalad Aug 8, 2024
97f0110
simplify
laurit Aug 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-adding enter advice suppress throwable
  • Loading branch information
LikeTheSalad committed Jun 28, 2024
commit 47e3749d81cec4641a3f3059bdb63770845073ad
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void transform(TypeTransformer transformer) {
@SuppressWarnings("unused")
public static class InfluxDbQueryAdvice {

@Advice.OnMethodEnter
@Advice.OnMethodEnter(suppress = Throwable.class)
@Advice.AssignReturned.ToAllArguments(index = 0, typing = Assigner.Typing.DYNAMIC)
public static Object[] onEnter(
trask marked this conversation as resolved.
Show resolved Hide resolved
@Advice.AllArguments(typing = Assigner.Typing.DYNAMIC) Object[] arguments,
Expand Down