Http server builder #11651
Merged
Http server builder #11651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
http-server-builder
branch
from
7abd2c2 to
5a9814d
Compare
zeitlinger
force-pushed
the
http-server-builder
branch
from
5a9814d to
a8db58f
Compare
zeitlinger
force-pushed
the
http-server-builder
branch
from
c08a511 to
489ef33
Compare
zeitlinger
force-pushed
the
http-server-builder
branch
from
489ef33 to
a0f1db3
Compare
zeitlinger
force-pushed
the
http-server-builder
branch
from
a0f1db3 to
ab9b52b
Compare
laurit
reviewed
Oct 1, 2024
...try/instrumentation/api/incubator/builder/internal/DefaultHttpClientInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 1, 2024
...-1.0/library/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v1_0/KtorServerTracing.kt
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 1, 2024
...brary/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/server/KtorServerTracing.kt
Outdated
Show resolved
Hide resolved
laurit
reviewed
Oct 1, 2024
...brary/src/main/kotlin/io/opentelemetry/instrumentation/ktor/v2_0/server/KtorServerTracing.kt
Show resolved
Hide resolved
laurit
reviewed
Oct 1, 2024
...ary/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/RatpackTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
test native
laurit
approved these changes
Oct 2, 2024
trask
reviewed
Oct 2, 2024
...try/instrumentation/api/incubator/builder/internal/DefaultHttpServerInstrumenterBuilder.java
Outdated
Show resolved
Hide resolved
Comment on lines
-28
to
+23
| AkkaHttpServerAttributesGetter httpAttributesGetter = new AkkaHttpServerAttributesGetter(); | ||
| InstrumenterBuilder<HttpRequest, HttpResponse> builder = | ||
| Instrumenter.<HttpRequest, HttpResponse>builder( | ||
| GlobalOpenTelemetry.get(), | ||
| AkkaHttpUtil.instrumentationName(), | ||
| HttpSpanNameExtractor.builder(httpAttributesGetter) | ||
| .setKnownMethods(AgentCommonConfig.get().getKnownHttpRequestMethods()) | ||
| .build()) | ||
| .setSpanStatusExtractor(HttpSpanStatusExtractor.create(httpAttributesGetter)) | ||
| .addAttributesExtractor( | ||
| HttpServerAttributesExtractor.builder(httpAttributesGetter) | ||
| .setCapturedRequestHeaders(AgentCommonConfig.get().getServerRequestHeaders()) | ||
| .setCapturedResponseHeaders(AgentCommonConfig.get().getServerResponseHeaders()) | ||
| .setKnownMethods(AgentCommonConfig.get().getKnownHttpRequestMethods()) | ||
| .build()) | ||
| .addOperationMetrics(HttpServerMetrics.get()) | ||
| .addContextCustomizer( | ||
| HttpServerRoute.builder(httpAttributesGetter) | ||
| .setKnownMethods(AgentCommonConfig.get().getKnownHttpRequestMethods()) | ||
| .build()); | ||
| if (AgentCommonConfig.get().shouldEmitExperimentalHttpServerTelemetry()) { | ||
| builder | ||
| .addAttributesExtractor(HttpExperimentalAttributesExtractor.create(httpAttributesGetter)) | ||
| .addOperationMetrics(HttpServerExperimentalMetrics.get()); | ||
| } | ||
| INSTRUMENTER = builder.buildServerInstrumenter(AkkaHttpServerHeaders.INSTANCE); | ||
| INSTRUMENTER = | ||
| JavaagentHttpServerInstrumenters.create( | ||
| AkkaHttpUtil.instrumentationName(), | ||
| new AkkaHttpServerAttributesGetter(), | ||
| AkkaHttpServerHeaders.INSTANCE); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since this big it'll be spit