-
Notifications
You must be signed in to change notification settings - Fork 871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spring boot starter failing without logback #10802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have a test that covers this scenario - maybe in smoke-tests-otel-starter
@zeitlinger I'm not sure how to test this. Perhaps you or @jeanbisutti can help with it? I definitely won't be able to make it for this release cycle. |
I'll prepare a PR targeting your branch |
For several reasons (one of them is to not test most of the things from one test project) it would make sense to test this issue in the same way as https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/spring/spring-boot-autoconfigure/src/testLogbackAppender. @zeitlinger Can I do this or would you like to do this? |
I think this would be better than creating a smoke test that would require separate image. The main hurdle in creating this test would be getting rid of the logback from the test class path. |
@zeitlinger I added a test, hope this is enough. |
It's better than what I came up with 😄 Only makes me a little bit depressed that gradle is so hard... |
Resolves #10784
Resolves #10612 (resolves the stack trace in #10612 (comment)
otel.sdk.disabled
part seems to already have been implemented in some other pr)