Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update alpha dependencies to alpha #10761

Closed

Conversation

zeitlinger
Copy link
Member

No description provided.

// (TODO remove once the artifacts above release stable versions)
"ignoreUnstable": false
"matchCurrentVersion": "/^.*-alpha$/",
"allowedVersions": "/^.*-alpha$/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this also auto-update from -alpha to a stable version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, allowedVersions describes which versions are allowed as new versions, which is the regex ^.*-alpha$

@zeitlinger zeitlinger added this to the v2.2.0 milestone Mar 11, 2024
zeitlinger added a commit to zeitlinger/opentelemetry-java-instrumentation that referenced this pull request Mar 11, 2024
@laurit
Copy link
Contributor

laurit commented Mar 11, 2024

@zeitlinger did you test this or do you guess that this should work?

@zeitlinger
Copy link
Member Author

zeitlinger commented Mar 11, 2024

I did not test it, but it should according to https://docs.renovatebot.com/configuration-options/#allowedversions

@laurit
Copy link
Contributor

laurit commented Mar 11, 2024

I did not test it, but it should according to https://docs.renovatebot.com/configuration-options/#allowedversions

To reduce the blast radius what do you think of keeping the matchPackageNames rules. Instead of matching against -alpha we could match agains not snapshot like in

"allowedVersions": "!/\\-SNAPSHOT$/"
I wouldn't be surprised if "ignoreUnstable": false is still needed.

@zeitlinger
Copy link
Member Author

Closed in favor of #10807

@zeitlinger zeitlinger closed this Mar 12, 2024
@zeitlinger zeitlinger deleted the alpha-dependencies branch March 12, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants