Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Lambda Runtime internal handlers need to be ignored from being instrumented and so traced. #10736

Conversation

serkan-ozal
Copy link
Contributor

@serkan-ozal serkan-ozal commented Mar 2, 2024

… Otherwise, there might be double root spans.

Fixes #7808

@serkan-ozal serkan-ozal requested a review from a team March 2, 2024 14:31
@serkan-ozal serkan-ozal force-pushed the fix/instrumentation/aws-lambda/ignore-aws-lambda-internal-handlers branch from b931fa8 to a4ed1bf Compare March 2, 2024 14:38
…strumented and so traced. Otherwise, there might be double root spans.
@serkan-ozal serkan-ozal force-pushed the fix/instrumentation/aws-lambda/ignore-aws-lambda-internal-handlers branch from a4ed1bf to 8621e84 Compare March 2, 2024 15:01
@laurit laurit added this to the v2.2.0 milestone Mar 6, 2024
@cleverchuk
Copy link
Contributor

@serkan-ozal please, it looks like we'll need same check here.

@serkan-ozal
Copy link
Contributor Author

serkan-ozal commented Mar 7, 2024

@cleverchuk I had not added it there because of SQSEvent check here:

Since SQSEvent class is not visible to AWS Lambda Runtime class loader (system class loader), I have thought that it is not needed. But just to be clear and be safe, I can add that check there too, WDYT?

@cleverchuk
Copy link
Contributor

@serkan-ozal Gotcha. It looks sufficient to not add anymore code. Thanks for pointing that out.

@trask
Copy link
Member

trask commented Mar 11, 2024

cc @tylerbenson

@trask trask merged commit e988d48 into open-telemetry:main Mar 12, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-top level server span created by lambda instrumentation
4 participants