Disable http and rpc metrics when advice can not be applied #10671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
approved these changes
Feb 26, 2024
|
I hadn't noticed this PR. Thanks for the work. It will indeed help to "workaround" trinodb/trino#20074. |
Note that for this to work trino would need to use a version of the instrumentation-api that contains this change. As they seem to update dependencies this should eventually happen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When advice can not be applied then most likely we'll end up with high cardinality metrics. This situation can arise because of bugs in other projects trinodb/trino#20074 that we can't do much about and also because of bugs in projects open-telemetry/opentelemetry-java-contrib#1190 where we could fix it.