Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update message queue (PRODUCER/CONSUMER) span names #983

Closed
trask opened this issue Aug 14, 2020 · 0 comments · Fixed by #1297
Closed

Update message queue (PRODUCER/CONSUMER) span names #983

trask opened this issue Aug 14, 2020 · 0 comments · Fixed by #1297
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome

Comments

@trask
Copy link
Member

trask commented Aug 14, 2020

As pointed out in #963 (comment), at least for JMS, we are not currently creating span name according to spec
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/messaging.md#span-name, and we should review / update other message queue instrumentation as needed also (Kafka, RabbitMQ)
@trask trask mentioned this issue Aug 14, 2020
Merged
malafeev pushed a commit to malafeev/opentelemetry-auto-instr-java that referenced this issue Sep 7, 2020
open-telemetry#983 add operation name to jms span name
9420e70 
Signed-off-by: Sergei Malafeev <[email protected]>
@malafeev malafeev mentioned this issue Sep 7, 2020
Merged
anuraaga pushed a commit that referenced this issue Sep 9, 2020
add operation name to jms span name (#1179)
8b62c17 
* #983 add operation name to jms span name

Signed-off-by: Sergei Malafeev <[email protected]>

* get rid of redundant method

Signed-off-by: Sergei Malafeev <[email protected]>
@iNikem iNikem added the contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome label Sep 14, 2020
@iNikem iNikem mentioned this issue Oct 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contribution welcome Request makes sense, maintainers probably won't have time, contribution would be welcome
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Messaging convention reviewed iNikem/opentelemetry-java-instrumentation
2 participants
@trask @iNikem