Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the opentelemetry-spring-boot-autoconfigure to Spring Boot 3 #7312

Closed
mateuszrzeszutek opened this issue Nov 25, 2022 · 2 comments
Closed

Update the opentelemetry-spring-boot-autoconfigure to Spring Boot 3 #7312

mateuszrzeszutek opened this issue Nov 25, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@mateuszrzeszutek
Copy link
Member

Now that Spring Boot 3 is out, we should probably update our own starter to the latest version.
@mateuszrzeszutek mateuszrzeszutek added the enhancement New feature or request label Nov 25, 2022
This was referenced Nov 25, 2022
Closed
Closed
This was referenced Jan 10, 2023
Closed
Merged
Merged
trask pushed a commit that referenced this issue Jan 12, 2023
Support Spring Web MVC in library instrumentation (#7552)
ca310b4 
Part of
#7312

This is pretty much a copy of the `spring-webvmc-5.3:library` module
with `s/javax/jakarta/` applied. I'm planning on removing the 5.3
instrumentation after #7312 is done.
trask pushed a commit that referenced this issue Jan 13, 2023
Support Spring Web 6 in library instrumentation (#7551)
ca85a0d 
Part of
#7312
@laurit laurit mentioned this issue Feb 10, 2023
Merged
mateuszrzeszutek pushed a commit that referenced this issue Feb 13, 2023
@laurit
Fix autoconfigure for spring boot 3 (#7784)
54d7241 
See
#7312
@mateuszrzeszutek mateuszrzeszutek mentioned this issue Feb 24, 2023
Closed
@jeanbisutti
Copy link
Member

@mateuszrzeszutek Could you please explain why?

Today, the OpenTelemetry Spring Starter works with Spring Boot 2 and Spring Boot 3.
Update to Spring Boot 3 will require to compile with Java 17.
So, update to Spring Boot 3 will limit the use cases for which the OpenTelemetry starter could be used.

@mateuszrzeszutek
Copy link
Member Author

Huh, I created this issue back when we had no support for Spring Boot 3. I think we've talked about several different approaches to handling this (e.g. separate starters for 2 and 3), but Lauri's managed to fix it without introducing any breaking changes.

Anyway, I think we can consider this issue closed by #7784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeanbisutti @mateuszrzeszutek