Avoid NullPointerException when jms destination is not available (#11570

)
open-telemetry · Jun 13, 2024 · 55e723e · 55e723e
1 parent f533bf3
commit 55e723e
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/.../src/main/java/io/opentelemetry/javaagent/instrumentation/jms/MessageWithDestination.java b/.../src/main/java/io/opentelemetry/javaagent/instrumentation/jms/MessageWithDestination.java
@@ -31,11 +31,13 @@ public static MessageWithDestination create(
       jmsDestination = fallbackDestination;
     }
 
-    if (jmsDestination.isQueue()) {
-      return createMessageWithQueue(message, jmsDestination);
-    }
-    if (jmsDestination.isTopic()) {
-      return createMessageWithTopic(message, jmsDestination);
+    if (jmsDestination != null) {
+      if (jmsDestination.isQueue()) {
+        return createMessageWithQueue(message, jmsDestination);
+      }
+      if (jmsDestination.isTopic()) {
+        return createMessageWithTopic(message, jmsDestination);
+      }
     }
     return new AutoValue_MessageWithDestination(
         message, "unknown", /* isTemporaryDestination= */ false);