Add CloudFoundry Resource Provider #1613
Open
+258
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new module, that parses the environment variable VCAP_APPLICATION for properties required for the CloudFoundry resource convention. This variable is present for applications running on CloudFoundry and contains all necessary information in a JSON object. Signed-off-by: Karsten Schnitter <[email protected]>
|
can you add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new module, that parses the environment variable VCAP_APPLICATION for properties required for the CloudFoundry resource convention. This variable is present for applications running on CloudFoundry and contains all necessary information in a JSON object.
This PR moves the code proposed in open-telemetry/opentelemetry-java-instrumentation#12861 to this repository
Existing Issue(s):
open-telemetry/opentelemetry-java-instrumentation#12861 and open-telemetry/opentelemetry-java-instrumentation#12862
Testing:
Unittests for the new functionality was added.
Documentation:
Please advise on necessary changes.
Outstanding items:
The could be a service name provider using the CloudFoundry application name, if no other source for the service name was found. I was unsure of the priority of such a provider, so I kept it for a later change.