Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[demo] update env variables #732

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Apr 6, 2023

Updates the environment variables for all components to align with this PR from the Demo repo.

Added a new default level environment variable for OTEL_EXPORTER_OTLP_METRICS_TEMPORALITY_PREFERENCE since this will be consistent for all components as they adopt metrics.

Re-ordered how some variables are listed to align with how the Demo repo has them set up. Generally speaking, they will be in this order:

  • Port for the component to bind to
  • addresses for downstream components
  • other specific component vars
  • OTEL vars

Signed-off-by: Pierre Tessier <[email protected]>
@puckpuck puckpuck requested a review from a team April 6, 2023 03:44
Signed-off-by: Pierre Tessier <[email protected]>
@dmitryax dmitryax merged commit c018b94 into open-telemetry:main Apr 6, 2023
@puckpuck puckpuck deleted the demo.update_env_variables branch April 6, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants