Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Presets for only logsCollection and hostMetrics #294

Merged
merged 13 commits into from
Aug 3, 2022
Merged

Presets for only logsCollection and hostMetrics #294

merged 13 commits into from
Aug 3, 2022

Conversation

TylerHelmuth
Copy link
Member

@TylerHelmuth TylerHelmuth commented Jul 28, 2022 •
edited
Loading

Implements presets for logsCollection and hostMetrics. config continues to contain default config. Use append to add filelog and hostmetrics receivers into user config.

Closes #158

@TylerHelmuth TylerHelmuth linked an issue Jul 28, 2022 that may be closed by this pull request
Replace default config with config presets #158
Closed
@TylerHelmuth TylerHelmuth mentioned this pull request Jul 28, 2022
Closed
@TylerHelmuth
Copy link
Member Author

TylerHelmuth commented Jul 29, 2022 •
edited
Loading

@dmitryax I have run make generate-examples and pushed the results so we can see how the changes affect things without wading through the chart bump changes. Once we are good with this approach i'll bump the chart and regenerate the examples.

@TylerHelmuth TylerHelmuth marked this pull request as ready for review July 29, 2022 20:13
@TylerHelmuth TylerHelmuth requested review from a team July 29, 2022 20:13
@TylerHelmuth
Copy link
Member Author

@dmitryax I believe I've addressed all unresolved comments. If all looks good I'll regenerate the examples for final review.

@TylerHelmuth
Copy link
Member Author

@dmitryax @Allex1 ready for final review

dmitryax
dmitryax approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Allex1 PTAL

@TylerHelmuth TylerHelmuth requested a review from Allex1 August 3, 2022 03:47
Allex1
Allex1 approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@Allex1 Allex1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐾 it

@dmitryax dmitryax merged commit 671510d into open-telemetry:main Aug 3, 2022
@TylerHelmuth TylerHelmuth deleted the issue-158-components branch August 3, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Allex1 Allex1 Allex1 approved these changes

@dmitryax dmitryax dmitryax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace default config with config presets
3 participants
@TylerHelmuth @dmitryax @Allex1