-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "add event" event handling #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Event` field is nowhere set. Instead `Message` and `Attributes` fields are filled with information from the event. So when handling the "add event" event, read the `Message` and `Attributes` fields, instead of `Event`, which is always `nil`. This avoids a crash.
For the record, the stack trace I was getting before the fix:
|
jmacd
approved these changes
Aug 15, 2019
tedsuo
approved these changes
Aug 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Since this is experimental, going to merge quickly.
6 tasks
hstan
referenced
this pull request
in hstan/opentelemetry-go
Oct 15, 2020
…97) As go mod tidy does have occasion to change `go.mod` files in addition to `go.sum` (e.g. when a transitive dependency changes from an implicit to explicit dependency), this new flag (`gomodsum_only`) allows the build to pass so long as the only files changed are either `go.mod` or `go.sum`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Event
field is nowhere set. InsteadMessage
andAttributes
fields are filled with information from the event. So when handling
the "add event" event, read the
Message
andAttributes
fields,instead of
Event
, which is alwaysnil
. This avoids a crash.I found this issue when testing my opentracing bridge with stdout exporter.