Unify trace and metric exporter helpers #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matej-g
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
paivagustavo
as code owners
MrAlias
reviewed
Jul 20, 2020
|
@MrAlias thanks for the feedback, I implemented the suggested changes |
MrAlias
reviewed
Jul 22, 2020
|
Other than the binary purge, this is looking good and should be approved afterwards. Great job 👍 |
jmacd
approved these changes
Jul 22, 2020
added 4 commits
July 22, 2020 09:37
- wait for the spans to be exported - rebuild the example
matej-g
force-pushed
the
unify-trace-and-metric-exporter-helpers
branch
from
0b26f9e
to
e0b7e3c
Compare
Sorry about that, removed the binary, hopefully now all is good 👍 |
lizthegrey
approved these changes
Jul 22, 2020
MrAlias
approved these changes
Jul 22, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings consistency to helper methods of trace and metric exporters (Prometheus, Jaeger, Zipkin). Each of these now has 3 helper methods with the same purpose:
NewRawExporter- method to return exporter only, with default or passed optionsNewExportPipeline- method which creates a new exporter and uses it to return a provider with recommended configurationInstallNewPipeline- same asNewExportPipeline, but it directly registers provider as globalSpecifically the changeset includes:
InstallNewPipelineand removedRegisterGlobaloption insteadNew tests, example updates and minor improvements (e.g. added documentation) are included here as well.
Related Issues:
Resolves #800