Batch Observer callback support #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmacd
requested review from
Aneurysm9,
krnowak,
lizthegrey,
MrAlias,
paivagustavo and
tedsuo
as code owners
|
@marwan-at-work Will you take a look? |
|
Here are the other possible APIs discussed in #634: #634 (comment) and lastly this, which was used for this PR: |
MrAlias
approved these changes
May 13, 2020
Closed
MrAlias
approved these changes
May 13, 2020
Aneurysm9
approved these changes
May 13, 2020
added 3 commits
May 13, 2020 16:21
Aneurysm9
reviewed
May 13, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the design discussed in #634 (comment) for batch observer callbacks.
Resolves #633.
See the spec-level issue:
open-telemetry/opentelemetry-specification#549